fix(analytics): count actual provider installations - #39
Merged
Conversation
Deploying scientfactory-website with
|
| Latest commit: |
fb718ce
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://554ce187.scientfactory-website.pages.dev |
| Branch Preview URL: | https://fix-provider-install-analyti.scientfactory-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundled provider entries could be mistaken for installed runtimes, and historical readiness could keep a removed provider in installation reports. Accept the generated revision-4 contract and count the latest explicit installed state per installation and provider within the report window.
Preserves older contract compatibility and existing consent, ingestion, export, notification, and activation controls. No UI changes.
Deployment order: deploy this backward-compatible gateway validator before releasing the companion desktop producer: ScientFactory/scient-desktop#268. The desktop merge itself does not release a new application.
Validation: 137 website tests passed; the opt-in cross-repository built desktop worker → gateway → ledger → mocked PostHog test passed separately. Worker/functions TypeScript checks, changed-file formatting, and generated contract parity passed. Full website build and live PostHog query execution were not run locally; CI remains required.
Quality and integration review: reviewed the contract allowlist, legacy compatibility, latest-state report semantics, and deployment ordering. Old discovery/readiness data is deliberately excluded from the installation metric because it does not contain explicit installed state.
Documentation impact: Updated — README.md.
Implementation: Codex assistant. Final delivery review: GPT-6 in Codex desktop.